Fix CI race in account creation tests#1864
Open
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
Open
Fix CI race in account creation tests#1864SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delay
server.listen()readiness callbacks until async server initialization completesmove single-user account cleanup into the Mocha
before()hookremove the race that caused CI coverage runs to fail with
EEXISTwhile creating thesingle-useraccount directoryCloses #1817
Testing
npx cross-env NODE_TLS_REJECT_UNAUTHORIZED=0 mocha --recursive test/integration/www-account-creation-oidc-test.mjs
npx cross-env NODE_TLS_REJECT_UNAUTHORIZED=0 c8 --reporter=text-summary mocha --recursive test/integration/www-account-creation-oidc-test.mjs
The original
EEXISTfailure no longer reproduces. Remaining local failures require hosts entries fornic.localhost,tim.localhost, andnicola.localhost.