Skip to content

Add Last-Modified header for GET and HEAD#1856

Open
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
SarthakDudhe:issue/1793-last-modified
Open

Add Last-Modified header for GET and HEAD#1856
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
SarthakDudhe:issue/1793-last-modified

Conversation

@SarthakDudhe
Copy link
Copy Markdown

Summary

  • add Last-Modified headers to successful GET and HEAD responses
  • use the file or container mtime as the header value
  • add integration coverage for both resources and containers

Fixes #1793.
Tests

  • npm run mocha-integration
  • npm run lint

Copy link
Copy Markdown
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Tested and seems to work as intended. I haven't run the tests.

@csarven csarven self-requested a review May 6, 2026 14:53
@bourgeoa
Copy link
Copy Markdown
Member

bourgeoa commented May 7, 2026

@SarthakDudhe Thanks for working on NSS. This is really needed. We may have discussion on what you could work on : implementing the Solid notifications spec !!!! or replacing inrupt OIDC client browser with UVDSL one.

@csarven
I think none of the solid servers does this.
The information is available in the Container not at Resource level
CSS does load the information in .meta (it was added for non filesystem to be able to render in Container).
This has made .meta only Patchable which is not Solid compliant.

@csarven
Copy link
Copy Markdown
Member

csarven commented May 7, 2026

@bourgeoa , it is required in Solid Protocol. It is also a server-controlled header, as opposed to a resource description, which may or may not be modifiable. The other advantage is being able to get this information using HEAD instead of fetching the whole resource payload with GET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server should include the Last-Modified header

3 participants