Skip to content

fix(session): use env var instead of argv for login re-entry marker - #202

Merged
Ly-sec merged 1 commit into
noctalia-dev:mainfrom
Yocraft-2000:fix/start-umbriel
Sep 9, 2026
Merged

Ly-sec merged 1 commit into
noctalia-dev:mainfrom
Yocraft-2000:fix/start-umbriel

Conversation

@Yocraft-2000

Copy link
Copy Markdown
Contributor

Summary

Use an exported UMBRIEL_LOGIN_REENTRY environment variable instead of a positional argument to detect login re-entry, since it survives an exec performed by the user's own login profile.

Motivation

Launching start-umbriel from ~/.bash_profile causes it to infinitely try to re-launch itself.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

Testing

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • This change fits SCOPE.md, or its scope was agreed in an issue or on Discord first.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

@Ly-sec

Ly-sec commented Sep 9, 2026

Copy link
Copy Markdown
Member

Looks good to me, thank you @Yocraft-2000

@Ly-sec
Ly-sec merged commit 94df375 into noctalia-dev:main Sep 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants