Skip to content

fix: apply is_alone window rule before the window opens, prevent flashing at default width - #200

Merged
ItsLemmy merged 1 commit into
noctalia-dev:mainfrom
Yocraft-2000:fix/alone-window-rule
Sep 12, 2026
Merged

ItsLemmy merged 1 commit into
noctalia-dev:mainfrom
Yocraft-2000:fix/alone-window-rule

Conversation

@Yocraft-2000

@Yocraft-2000 Yocraft-2000 commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A window that opens as the sole tiled window on its workspace is now configured from the first configure and at attach in its match.is_alone rule state (width, fullscreen, maximize).
That state is owned by the alone rule, so it reverts as soon as a second window opens, without ever taking over a state the client itself requested (e.g. mpv opening fullscreen on its own).

Motivation

The window flash at default width before applying the rule.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

Testing

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • This change fits SCOPE.md, or its scope was agreed in an issue or on Discord first.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

@Noctalia-CI
Noctalia-CI marked this pull request as draft September 9, 2026 15:50
@Noctalia-CI

Noctalia-CI commented Sep 9, 2026 •

Copy link
Copy Markdown

The description now contains the required template structure.

@Yocraft-2000
Yocraft-2000 marked this pull request as ready for review September 9, 2026 15:59
@ItsLemmy
ItsLemmy merged commit f8a9fd9 into noctalia-dev:main Sep 12, 2026
4 of 5 checks passed
@ItsLemmy

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants