fix(input): keep modifier-only binds alive while an input method is active - #196
Merged
Merged
Conversation
Contributor
|
Thanks, reworked it a bit so that it exclude only IME keyboards from modifier taps and not all virtual keyboards, since our test harness use virtual keyboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only let physical keyboards arm modifier taps; virtual-keyboard echoes no longer cancel them.
Motivation
An input method grabs the physical keyboard and echoes each forwarded key back through its own virtual keyboard. Every key press cancels the pending modifier tap (armModifierTap starts with cancelForKeyPress), so the virtual echo of a held modifier cancels the physical tap and the modifier-only bind never fires on release. Combination binds are unaffected because they match on press.
Type of Change
Related Issue
Closes #139
Testing
just checkand manual testManual Coverage
Screenshots / Videos
Checklist
SCOPE.md, or its scope was agreed in an issue or on Discord first.CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.Additional Notes