Alacritty template fix#2582
Open
notmugi wants to merge 2 commits intonoctalia-dev:mainfrom
Open
Conversation
Author
|
sorry for the second commit, was using some testing values and didnt realize it, swapped them back to their defaults which shouldnt matter (?) i think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
Alacritty was generating colors that were not in line with the other terminals available. i.e foot, kitty. it had hardcoded hex values that were obviously not getting changed when colorschemes got generated.
Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
tried to match the generation as close as possible to kitty and foot, looked at their templates and then did some testing on multiple wallpapers. dark and light generation examples in pictures below to show the issue is resolved
Screenshots / Videos
Dark and light generation test with a color block to show consistency. top terminal is kitty, bottom is alacritty.


Checklist
Additional Notes
please let me know if I've used the incorrect values for some of these, I'm fairly new to stuff like this and this is even my first PR on github as a whole. willing to go back and fix something if need-be