feat(lockscreen): add lockscreen-specific wallpaper target in unified wallpaper selector#2574
Open
bitbloxhub wants to merge 1 commit intonoctalia-dev:mainfrom
Open
feat(lockscreen): add lockscreen-specific wallpaper target in unified wallpaper selector#2574bitbloxhub wants to merge 1 commit intonoctalia-dev:mainfrom
bitbloxhub wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
bitbloxhub
force-pushed
the
lockscreen-wallpaper
branch
from
09d1c65 to
c0f34f1
Compare
… wallpaper selector Fixes noctalia-dev#1641 Written mostly by an LLM since I don't know QML, works fine from my testing however. Currently there seems to be a very small (0.5s?) delay before loading the image with a custom lockscreen wallpaper set when locking, if anyone has any idea why or how to fix, please share! - add lockscreen wallpaper light/dark settings and service APIs - expose desktop vs lockscreen target tabs in Wallpaper panel - fallback to desktop wallpaper when lockscreen wallpaper unset - allow selector access when wallpaper management disabled via lockscreen override toggle Co-authored-by: pi with GPT-5.3-Codex <pi-gpt-5.3-codex@codex.local>
bitbloxhub
force-pushed
the
lockscreen-wallpaper
branch
from
c0f34f1 to
4712335
Compare
Author
|
(Looks like I picked a bad time to do this, https://noctalia.dev/blog/announcing-noctalia-v5, not sure if I dislike QML or C++ more ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
Adds wallpaper settings for lockscreen specific wallpapers and support for using them even when regular wallpapers are disabled.
Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
Regularly with AWWW/SWWW daemon for wallpaper:
Lockscreen:
Checklist
Additional Notes
Written mostly by an LLM since I don't know QML, works fine from my testing however and code looks fine to me.
Currently there seems to be a very small (0.5s?) delay before loading the image with a custom lockscreen wallpaper set when locking, if anyone has any idea why or how to fix, please share!