Implement media volume handling#2557
Open
Scrumplex wants to merge 3 commits intonoctalia-dev:mainfrom
Open
Conversation
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Contributor
Author
|
I guess I could also add a volume bar to the popup of MediaMini |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
85abe5f to
8965aa6
Compare
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
I used to change my media volume by scrolling over my MPD component when I was
using waybar.
This adds that behavior to MediaMini and hooks the media volume up to OSD.
Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
I was running my code and used mpdris2 to change the volume of my music. It
works in both directions, so changes through mpc get shown in the OSD and vice
versa.
Note that Quickshell exposes
volumeandvolumeSupported. I have not tested how this behaves withvolumeSupported = falseSee https://github.com/noctalia-dev/noctalia-qs/blob/75d180c28a9ab4470e980f3d6f706ad6c5213add/src/services/mpris/player.hpp#L147-L149
Screenshots / Videos
If applicable, include screenshots or videos to help illustrate your changes.
Checklist
Additional Notes
I think this should have other icons in the OSD, but I wasn't sure how to addI chose to usenew icons to the ttf. At the same time, Tabler does not have any other volume
icons, though we could use
musicandmusic-offkinda like how the inputvolume OSD works.
musicandmusic-offOne oddity I noticed is that
onWheelofMouseAreagives different valuesthan
onWheelofItem(as used in the Volume widget). The magic number 120probably needs to be tweaked due to this. Alternatively, we could switch all
other widgets to use
MouseAreato make this more consistent.