fix(usb-drive-manager): use standard error hover colors for eject button#771
Open
Electronic-Mango wants to merge 1 commit intonoctalia-dev:mainfrom
Open
fix(usb-drive-manager): use standard error hover colors for eject button#771Electronic-Mango wants to merge 1 commit intonoctalia-dev:mainfrom
Electronic-Mango wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
Contributor
|
@hennifant - this PR modifies your plugin. Please review when you have a chance. |
Electronic-Mango
force-pushed
the
usb-drive-manager-eject-colors
branch
from
be37e68 to
d1c47ec
Compare
Contributor
Author
|
I updated plugin version to 1.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use standard error colors -
Color.mErrorandColor.mOnError- for the "eject" button; instead of the "error container" ones. Initially I thought of using the standard "hover" colors, but this should give the "eject" button different color to the rest of them.This should fix the "eject" button being black when hovering over it.
I'm not sure where the
mErrorContainerandmOnErrorContainershould be from; noctalia-shell doesn't have them defined.