Skip to content

fix(eyecare): use current theme for widget text color - #624

Draft
MrFreezeex wants to merge 1 commit into
noctalia-dev:mainfrom
MrFreezeex:fix-eyecare-color
Draft

fix(eyecare): use current theme for widget text color#624
MrFreezeex wants to merge 1 commit into
noctalia-dev:mainfrom
MrFreezeex:fix-eyecare-color

Conversation

@MrFreezeex

@MrFreezeex MrFreezeex commented Sep 4, 2026

Copy link
Copy Markdown

Plugin

  • Id: apex077/eyecare
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

This updates the eyecare plugin to use the user theme color instead of hardcoded color

External dependencies

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: 5.0.1
  • Plugin API level:

Screenshots / Videos

Before it looks like that in my environment:
image

And now like that:
image

(also the break one looks pretty similar as before for me:)
image

Checklist

Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • thumbnail.webp is present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

CC @Apex077 — this pull request was automatically moved to draft until you have had a chance to look at it. It will be marked ready for review automatically once you reply here.

Comment thread eyecare/widget.luau
barWidget.setTooltip(string.format("Eye-Care timer active.\nTime remaining: %s\nClick to start break manually\nRight-click to reset", formatTime(remaining)))
barWidget.setGlyphColor("#00e676") -- Vibrant Green
barWidget.setColor("#ffffff")
barWidget.setGlyphColor("primary")

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to have this glyph in the same color as the text too (like having on_surface here), not entirely sure which one is best 🤷‍♂️

Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
@MrFreezeex MrFreezeex changed the title fix(eyecare): use current them for widget text color fix(eyecare): use current theme for widget text color Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant