Repository navigation
Support mbmap spec 2.1.0, more vendor icons, Russian README - #208
Merged
Merged
Conversation
- identify block (FC17/FC43) read, validated and used by Check device - read_alone / read_group honoured when planning reads - favicon service fallback for vendor sites that refuse automated requests - new compatible-.mbmap badge - README in Russian - update mbmap-library to the latest main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
identify(FC17/FC43) is read, validated (bad-identify), written back and used by Check device (app and CLI) to compare model and firmware. Registers with aroletake priority.read_alone/read_groupare validated (bad-read) and honoured by the read planner (poller, Node-RED export).mbmap-library/testsgive the errors listed in itsexpected.json.compatible-.mbmapbadge; Russian translation (docs/readme/README_RU.md) and language switcher entries.vendor/mbmap-libraryupdated to the latest main.abb/acs355.Known limitation
FC17 answers whose run-indicator byte is not
0x00/0xFFare rejected bytokio-modbus, so the check is "unknown" for those devices (e.g. Lovato DMG610). FC43 is complete. Needs a small patch totokio-modbusto fix.Not done
The map builder UI has no fields for
identify,read_aloneorread_groupyet (TS types only).Tests
cargo test,cargo clippy --all-targets -- -D warnings,npm run checkandnpm testpass.