Repository navigation
Remember the manual request across restarts (#205) - #206
Merged
Merged
Conversation
Command, start address, quantity and Loop of step 2 are saved when they change and filled in again at start, under the existing "Remember the last connection" setting. Saved values that do not fit are ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205.
The manual request of step 2 (command, start address, quantity and Loop) always started as FC03 / 0 / 10 / Loop on, so it had to be set again after every restart.
What changes
src/lib/state.svelte.ts: the request is saved tomodbench.requestin localStorage whenever it changes (quantity, Loop, command, address) and when a test starts, and is filled in again at start. Saved values that are not a valid function code, address or quantity for that command are ignored, so the defaults apply.Tests
state.test.ts: the request is saved and picked up by a fresh start; a saved request that does not fit is ignored.npx vitest run: 228 passed.npm run check: 0 errors, 0 warnings.