feat: introduce @noaignite/next-klaviyo package - #801
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ff7ed1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
836c5fb to
efa56fd
Compare
efa56fd to
ff7ed1d
Compare
| } | ||
| } | ||
|
|
||
| export {} |
There was a problem hiding this comment.
question: What does this do? Is it to disable automatic exports? Perhaps nice to add a simple explanation :)
// Disable automatic export
export {}
| export { klaviyo } from './klaviyo' | ||
| export { KlaviyoObject } from './KlaviyoObject' | ||
| export { KlaviyoScript } from './KlaviyoScript' | ||
| export type { KlaviyoScriptProps } from './KlaviyoScript' |
There was a problem hiding this comment.
question: Why not just export *?
| "default": "./src/index.ts" | ||
| } | ||
| }, | ||
| "types": "./src/index.ts", |
There was a problem hiding this comment.
question: is this needed? I was in the understanding that the exports field is enough :)
| "files": [ | ||
| "src", | ||
| "dist" | ||
| ], |
There was a problem hiding this comment.
question: Do we need/want to publish both src & dist?
| "exports": { | ||
| ".": { | ||
| "types": "./src/index.ts", | ||
| "default": "./src/index.ts" | ||
| } | ||
| }, |
There was a problem hiding this comment.
question: What's the build script for if we point to src and not dist? Probably some faulty wiring here :)
| "react": "^18.0.0 || ^19.0.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">=20.0.0" |
There was a problem hiding this comment.
todo(non-blocking): We should probably raise this to at least version 22 which is actively maintained :)
maeertin
left a comment
maeertin
left a comment
There was a problem hiding this comment.
Great work @adamsoderstrom 🥳 Left you some questions/todos. Resolve them and merge when you feel ready.
3 participants
No description provided.