Skip to content

Benchmark turns off CSRF protection #2

Description

@noahgibbs

That's not a big problem for accuracy, but it's a sign that something's wrong. Nothing notable changed in Discourse between versions where CSRF works (1.7.8 and before) and Discourse versions where CSRF stops working (1.8.0.betaX series.) The CSRF problems can be reproduced in Ruby 2.3.X, so it's not a Ruby 2.4.0 problem. It might be a Rails problem, but the difference in Rails versions between Discourse 1.7.8 and 1.8.0 is small enough that it's unlikely. More likely some weird tooling/config problem that happens to have been randomly tickled.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions