fix(eval): drop dead Swahili prompt load that broke CI - #72
Merged
Conversation
The evaluation harness's prompts.py still loaded config/prompts/system_sw.txt at import (APP_SYSTEM_PROMPT_SW) — but that file was deleted in the English-only change, so 5 test_imports.py tests failed on main (FileNotFoundError). The symbol was never used and the import tests only assert APP_SYSTEM_PROMPT (English), so remove the line. All test_imports + scoring tests green locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rb8sCfVzRDRZko7V5JYxUB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the English-only change (PR #71). The evaluation harness's
prompts.pystill loaded the now-deletedconfig/prompts/system_sw.txtat import, failing 5test_imports.pytests on main. TheAPP_SYSTEM_PROMPT_SWsymbol was never used and the tests only assert the English prompt, so the line is removed. All test_imports + scoring tests pass locally.🤖 Generated with Claude Code