Hotfix/update dependencies#231
Draft
nmdickson wants to merge 9 commits into
Draft
Conversation
Namely, SSPtools and limepy have had important updates that we are now going to explicitly require.
With ssptools>3.0.0, the `BH_ret_int` parameter is removed entirely and the `BH_ret_dyn` parameter now means something different, as it does not include the natal kicks. To make this breaking change explicit, I'm removing `BHret` entirely in favour of the actual `BH_ret_dyn`. Nothing functionally changes about how it is used, but its meaning has changed.
Introduced in limepy 1.3.0, these new conditions will mean that we no longer have to guess at a much lower diffcrit than the default just to avoid having the BH bins way off of the inputs. The default 0.1% in each bin should be enough now.
These must be explicitly arguments, not just in `MF_kwargs` because they must be passed to clusterBH as well
The underlying models should be the exact same, for the most part, but the cBHBd package will be the stable package.
The non-evolved model does not know N0, so the `EvolvedMF` it uses is not normalized to the correct mass, which only happens in limepy. So whenever `model._mf` is used in static models, the overall mass needs to have this scale factor applied again.
Owner
Author
|
I won't merge this until the cBHBd library itself is made public, and the limepy PR is merged and released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update is about bringing a few important dependencies up to date.
Limepy version requirements are updated to make sure we are using all the latest equipartition and related fixes from limepy#22 (v1.3.0).
SSPtools is updated to use all the changes to the kicks completed in ssptools#18 and to allow for using the various new IFMRs (v3.1.0)
clusterBH is now being imported and used from the cBHBd package, not the standalone un-updated clusterBH package.