Skip to content

Fix ambiguous static_cast#5221

Merged
nlohmann merged 5 commits into
developfrom
fix/4825-bjdata-ndarray-cast
Jul 2, 2026
Merged

Fix ambiguous static_cast#5221
nlohmann merged 5 commits into
developfrom
fix/4825-bjdata-ndarray-cast

Conversation

@nlohmann

Copy link
Copy Markdown
Owner

Replaced the ambiguous static_cast<string_t>(value.at(key)) with value.at(key).template get<string_t>() to fix #4825.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann added this to the Release 3.12.1 milestone Jun 30, 2026
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jun 30, 2026
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@github-actions github-actions Bot added M and removed S labels Jun 30, 2026
@nlohmann nlohmann removed the review needed It would be great if someone could review the proposed changes. label Jun 30, 2026
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as draft June 30, 2026 16:14
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as ready for review July 1, 2026 07:57
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jul 1, 2026
@nlohmann nlohmann merged commit 31dd15b into develop Jul 2, 2026
142 checks passed
@nlohmann nlohmann deleted the fix/4825-bjdata-ndarray-cast branch July 2, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M review needed It would be great if someone could review the proposed changes. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template instantiation of nlohmann::basic_json<> fails on C++17

1 participant