This repository was archived by the owner on Jan 13, 2023. It is now read-only.
* updated to UE4.24.2#7
Open
KrisRedbeard wants to merge 1 commit into
Open
Conversation
|
Hey, thanks a lot for taking the time to update to 4.24. Could you do for 4.23 too please? Would appreciate it a lot! :D |
SaxonRah
approved these changes
Feb 7, 2020
nlebedenco
reviewed
Feb 9, 2020
| FRotator UArmComponent::GetTargetRotation() const | ||
| { | ||
| FRotator DesiredRotation; | ||
| FRotator DesiredRotation = GetComponentRotation(); |
Owner
There was a problem hiding this comment.
With this change DesireRotation may get assigned twice and if GetComponentRotation() has any functional or performance side effects they will be always imposed. If you want to get rid of the goto do
FRotator DesiredRotation;
APawn* OwningPawn;
if (bUsePawnControlRotation && (OwningPawn = Cast<APawn>(GetAttachmentRootActor())))
DesiredRotation = OwningPawn->GetViewRotation() + GetRelativeRotation();
else
DesiredRotation = GetComponentRotation();
One may argue that this also changes the code in the sense that now OwningPawn is defined in the method scope and not restricted anymore to the if block but this is just a semantic change that has no impact in the generated instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ABP_Mannequin was modified to use a reference pose by default, with a note to reconnect the rest of the nodes once animations are set.