Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

* updated to UE4.24.2#7

Open
KrisRedbeard wants to merge 1 commit into
nlebedenco:masterfrom
KrisRedbeard:master
Open

* updated to UE4.24.2#7
KrisRedbeard wants to merge 1 commit into
nlebedenco:masterfrom
KrisRedbeard:master

Conversation

@KrisRedbeard

Copy link
Copy Markdown

ABP_Mannequin was modified to use a reference pose by default, with a note to reconnect the rest of the nodes once animations are set.

@Zod20

Zod20 commented Feb 7, 2020

Copy link
Copy Markdown

Hey, thanks a lot for taking the time to update to 4.24. Could you do for 4.23 too please? Would appreciate it a lot! :D

@KrisRedbeard KrisRedbeard changed the title * updated to UE4.24.4 * updated to UE4.24.2 Feb 7, 2020
FRotator UArmComponent::GetTargetRotation() const
{
FRotator DesiredRotation;
FRotator DesiredRotation = GetComponentRotation();

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change DesireRotation may get assigned twice and if GetComponentRotation() has any functional or performance side effects they will be always imposed. If you want to get rid of the goto do

FRotator DesiredRotation;
APawn* OwningPawn;
if (bUsePawnControlRotation && (OwningPawn = Cast<APawn>(GetAttachmentRootActor())))
     DesiredRotation = OwningPawn->GetViewRotation() + GetRelativeRotation();
else 
     DesiredRotation = GetComponentRotation();

One may argue that this also changes the code in the sense that now OwningPawn is defined in the method scope and not restricted anymore to the if block but this is just a semantic change that has no impact in the generated instructions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants