No module named 'comfy.sd2_clip'

[AlexK98]

ComfyUI portable 0.3.45.
Seems like there is a compatibility problem as sd2_clip class changed its location.

Traceback (most recent call last):
  File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2124, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 999, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\__init__.py", line 1, in <module>
    from .py.nodes.node import SaveImageWithMetaData
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\__init__.py", line 3, in <module>
    from .hook import pre_execute, pre_get_input_data
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\hook.py", line 1, in <module>
    from .nodes.node import SaveImageWithMetaData
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\nodes\node.py", line 19, in <module>
    from ..capture import Capture
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\capture.py", line 5, in <module>
    from .defs.captures import CAPTURE_FIELD_LIST
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\defs\__init__.py", line 5, in <module>
    from .captures import CAPTURE_FIELD_LIST
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\defs\captures.py", line 3, in <module>
    from .formatters import (
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\defs\formatters.py", line 10, in <module>
    from comfy.sd2_clip import SD2Tokenizer
ModuleNotFoundError: No module named 'comfy.sd2_clip'

[Mossbraker]

You can fix it by changing line 10
from comfy.sd2_clip import SD2Tokenizer
to from comfy.text_encoders.sd2_clip import SD2Tokenizer
in the file py\defs\formatters.py

Edit: However, it looks like the location of sd2_clip was actually changed over a year ago and the above change was already implemented. Updating SaveImageWithMetaData custom nodes should fix the issue.

[AlexK98]

You can fix it by changing line 10 from comfy.sd2_clip import SD2Tokenizer to from comfy.text_encoders.sd2_clip import SD2Tokenizer in the file py\defs\formatters.py

I already did this for my local copy, but having this fixed in original repo would be much more preferable.

[rodsott]

You can fix it by changing line 10 from comfy.sd2_clip import SD2Tokenizer to from comfy.text_encoders.sd2_clip import SD2Tokenizer in the file py\defs\formatters.py

Edit: However, it looks like the location of sd2_clip was actually changed over a year ago and the above change was already implemented. Updating SaveImageWithMetaData custom nodes should fix the issue.

Just did your suggestion, but did not work for me... It gave me this:

Traceback (most recent call last):
File "X:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2129, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 999, in exec_module
File "", line 488, in call_with_frames_removed
File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata_init.py", line 1, in
from .py.nodes.node import SaveImageWithMetaData
File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py_init_.py", line 3, in
from .hook import pre_execute, pre_get_input_data
File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\hook.py", line 1, in
from .nodes.node import SaveImageWithMetaData
File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\nodes\node.py", line 19, in
from ..capture import Capture
File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\capture.py", line 5, in
from .defs.captures import CAPTURE_FIELD_LIST
File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata\py\defs_init_.py", line 16, in
module = importlib.import_module(package_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "importlib_init_.py", line 90, in import_module
ModuleNotFoundError: No module named 'custom_nodes.ComfyUI-SaveImageWithMetaData'

Cannot import X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-saveimagewithmetadata module for custom nodes: No module named 'custom_nodes.ComfyUI-SaveImageWithMetaData'

@Mossbraker Any clue? I needed to rename the folder to exactly ComfyUI-SaveImageWithMetaData, so now it works.. Strange that installing it from Manager did not bring the folder name like this, with caps..

[Mossbraker]

I think line 2 in pyproject.toml where it sets name = "comfyui-saveimagewithmetadata" is what causes ComfyUI-Manager to use an incorrect folder name. The line needs to be changed to name = "ComfyUI-SaveImageWithMetaData" to correct the issue.

[AlexK98]

@rodsott that's because import directive is Case Sensitive. So, when you install this particular package from within the Manager in ComfyUI it creates folder, as @Mossbraker mentioned, in all lowercase chars, but path to module is in CamelCase. And that is the problem.

[rodsott]

Thank you @Mossbraker and @AlexK98 for the feedback!

It would be good that @nkchocoai could fix this, or warn about this question at the readme.md, if its a matter of Manager or Comfy itself, so other users could solve this and make this cool custom node work flawlessly. ^_^

[GrLoopBack]

The error is back.
What's really weird is that the /ComfyUI/comfy/text_encoders/sd2_clip.py is where it has been for a while and I did not get this error before.

[Mossbraker]

You could give my fork a try. I've added compatibility with a lot of other node packs and some extra features and it's working fine right now as far as I can see.