Fix Trakt watched sync for enforced pagination and extended=progress - #968
Open
twes33 wants to merge 1 commit into
Open
Fix Trakt watched sync for enforced pagination and extended=progress#968twes33 wants to merge 1 commit into
twes33 wants to merge 1 commit into
Conversation
Trakt now enforces pagination on /sync/watched/{type} (previously a
single request returned the full history) and no longer returns
season/episode progress data under extended=full for shows.
Switch both sync_watched_episodes and _sync_watched_movies to
get_all_pages_json (already used elsewhere for sync/ratings and
sync/playback) and request extended=progress for the shows endpoint,
which is the only supported way to get season data back under
Trakt's new API behavior.
See trakt/trakt-api#775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trakt now enforces pagination on
/sync/watched/{type}(previously a single request returned the full watched history) and no longer returns season/episode progress data underextended=fullfor shows — see trakt/trakt-api#775 for the announcement.Fixes #967.
_sync_watched_moviesandsync_watched_episodesnow useget_all_pages_json(already the established pattern forsync/ratingsandsync/playback) instead of a singleget_jsoncall, so watched history isn't silently truncated to the first page.sync_watched_episodesnow requestsextended=progressinstead of the deprecatedextended=full, which is required to get season/episode data back under Trakt's new behavior.Test plan