Repository navigation
fix(web): stop a long tool list from scrolling the whole window - #311
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
sugabots-website | a9a2889 | Oct 06 2026, 06:09 AM |
davemooreuws
force-pushed
the
connection-page-scroll
branch
from
October 6, 2026 06:08
f61cbb1 to
a9a2889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connection with hundreds of tools, such as PostHog's, gave the window a second scrollbar, and scrolling it pushed the app up and left empty space below. Each tool's Allow / Ask / Off radios are hidden with
sr-only, which positions them absolutely. Nothing above them was positioned, so they were placed against the page and stretched it to the bottom of the list.The settings scroll area is now
relative, asPanesalready is for chat, so the radios, and anything else a settings page hides for screen readers, stay inside the panel.The new
HundredsOfToolsstory in ConnectionPage opens a connection with 300 tools and checks the window doesn't scroll. It fails without the fix.Closes SUGA-1951