fix: map CC spine01/02 (#112) - #126
Open
AquaticAzelf wants to merge 1 commit into
Open
Conversation
Fixes nirholas#112: CC_Base_Spine01/02 were not mapped, causing bind-pose. Handle Spine01/02 explicitly before alias table to avoid colliding with Mixamo Spine_02 dedup.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112.
CC_Base_Spine01/CC_Base_Spine02(Reallusion CC3/CC4) were not mapped, causing entire CC rig to fall through to bind-pose.Problem
src/glb-canonicalize.js:444comment says CC prefix is stripped, butSpine01/Spine02(no separator) had no alias, soCC_Base_Spine01→Spine01→spine01→null.['spine01','Spine']/['spine02','Spine1']toEXTRA_ALIASEScollides with Mixamo'sSpine_02dedup (Spine_02→ dedupSpine→Spine, butspine_02normalizes tospine02and would incorrectly hitSpine1).Solution
src/glb-canonicalize.js:444-450— handleSpine01/Spine02explicitly before the general alias table, afterCC_Base_strip:CC_Base_Spine01→Spine01→SpineCC_Base_Spine02→Spine02→Spine1spine01/spine02without prefix also map correctlySpine_02/mixamorig:Spine_02still dedup toSpine(notSpine1) — preserves existing testexpect(canonicalizeBoneName('mixamorig:Spine_02')).toBe('Spine')Verification (folder-local, no global installs)
raw.githubusercontent.comtoC:\Users\Azelf\AppData\Local\Temp\opencode\three-ws-minimal(full clone timed out due to large assets, used minimal folder)npm init -y,npm install three(folder-local),npm pkg set type=modulenode test.mjs:CC_Base_Spine01→Spine✓CC_Base_Spine02→Spine1✓spine01→Spine✓spine02→Spine1✓mixamorig:Spine_02→Spine✓ (regression)spine_02→Spine✓CC_Base_Hip→Hips✓npm install -g, nopip, just folder-localnode.Stars: 105★ (not zero), 7 open issues, updated 2026.
Closes #112