Repository navigation
Retry the permission dialog when its button goes stale - #7
Merged
Merged
Conversation
The weekly run failed TC-131 with a StaleElementReferenceException: the button was found, then the dialog was redrawn before its text was read. Finding, reading and tapping are now one step of the wait, so a stale button is found again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly run (41962058591) failed twice on the same commit:
adb: device offline), so most tests failed. That was the runner, and this PR doesn't change it.StaleElementReferenceExceptionon the permission button: it was found, then was gone from the page beforegetText().PermissionDialog.allowOnenow finds, reads and taps the button inside the wait, and the wait ignores stale elements, so a redrawn dialog is found again. If the dialog really has gone, the wait times out as before.The race can't be triggered on demand, so a green run shows nothing broke, not that the race is gone.
🤖 Generated with Claude Code