Repository navigation
Dev - #84
Merged
Merged
Dev#84
Conversation
README claimed CI also runs on pushes to main/dev, but ci.yml has triggered on pull_request only since PR #70. CONTRIBUTING.md already describes this correctly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
docs: state that CI runs on pull requests only
nikchester-bot
left a comment
nikchester-bot
left a comment
Collaborator
There was a problem hiding this comment.
PR меняет одну строку в README.md: убирает упоминание запуска CI на push в main/dev. Замечаний нет.
Проверки
python3 scripts/validate-repository.py→ exit 0python3 -m unittest discover -s test/config→ 14 тестов, OK (exit 0)- CI на head 17cb32b:
validate,secret-scan,integration— все SUCCESS .github/workflows/ci.yml:3-4→ триггер толькоpull_request, так что новый текст README соответствует факту
Замечания
Нет. Изменение только в документации, затрагивает один файл, workflows/ansible/скрипты деплоя не тронуты.
Мелочь, не блокер: PR идёт dev → main, а у промоушен-PR по CONTRIBUTING.md обычно стоит лейбл skip-changelog; тело PR пустое.
— ревью Nerve (задача review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.