Skip to content

Prune stale Window Layout handles - #112

Merged
niharnm merged 3 commits into
mainfrom
nihar/window-handle-integration
Sep 9, 2026
Merged

niharnm merged 3 commits into
mainfrom
nihar/window-handle-integration

Conversation

@niharnm

@niharnm niharnm commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Window Layout kept records for closed windows and ended applications, eventually reaching the shared 2,000-handle cap and refusing new windows. Focused lookup now removes confirmed stale process identities and performs at most four rotating checks of earlier Window Layout handles before allocating another.

Only a confirmed invalid AX element or stale process identity removes a record. Timeouts, missing metadata, permission errors and other inconclusive results retain it. Existing restore records survive the cap, Workspace enumeration cannot remove Window Layout records, and cancellation and deadline checks precede each probe. A full table can still refuse an action when its bounded pass finds no confirmed stale entry; later lookups continue the rotation.

Validation:

  • A fresh signed Debug build and four strict signature checks passed at combined source 245ffb4. All 2,253 compiled unit tests in 256 suites passed, with no exclusions. Final head 6ce2ad3 differs only in three reviewed documentation files; all app and test input hashes are unchanged.
  • Independent frozen-source verification passed 51 Window Layout and handle-store tests in three suites. Owner verification passed 156 scoped tests in ten suites and both app and test builds.
  • The store regression covers 4,000 distinct entries, active record retention, process identity changes, transient failures, fair bounded probing, the shared cap and shutdown. Its maintenance-disabled comparison is a model test, not a native baseline run or performance benchmark.
  • Independent backend/store reviews found no remaining issues. Final source hashes match those reviews. Documentation review and 60 relative links/anchors passed; the docs now reflect Shelf integration through PR111. Website files are unchanged.

The ordinary signed Release build and strict signature check passed at exact head 6ce2ad3, with no warnings. The app was not launched. Exact-head CI34401335479 passed both required checks: build-and-test and website-smoke. The optional Vercel preview hit the daily deployment limit; website bytes are unchanged from verified production. CodeRabbit did not perform a review because of its quota; the independent source reviews above are the review evidence. Native AX timing, focus, permissions, keyboard and VoiceOver acceptance remain pending. No benchmark measurements or new public binary are included.

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

Deployment failed for project semper with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/niharnsm-8472s-projects?upgradeToPro=build-rate-limit

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 94161ea8-acb4-4277-a7c5-122d0f229fd2

📥 Commits

Reviewing files that changed from the base of the PR and between ced1a2b and 6ce2ad3.

📒 Files selected for processing (6)
  • README.md
  • ROADMAP.md
  • Semper/Workspace/WorkspaceWindowBackend.swift
  • Semper/Workspace/WorkspaceWindowHandleStore.swift
  • SemperTests/WorkspaceWindowHandleStoreTests.swift
  • guide/product-status.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@niharnm
niharnm merged commit 20ab341 into main Sep 9, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant