Prune stale Window Layout handles - #112
Merged
Merged
Conversation
|
Deployment failed for project semper with the following error: Learn More: https://vercel.com/niharnsm-8472s-projects?upgradeToPro=build-rate-limit |
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window Layout kept records for closed windows and ended applications, eventually reaching the shared 2,000-handle cap and refusing new windows. Focused lookup now removes confirmed stale process identities and performs at most four rotating checks of earlier Window Layout handles before allocating another.
Only a confirmed invalid AX element or stale process identity removes a record. Timeouts, missing metadata, permission errors and other inconclusive results retain it. Existing restore records survive the cap, Workspace enumeration cannot remove Window Layout records, and cancellation and deadline checks precede each probe. A full table can still refuse an action when its bounded pass finds no confirmed stale entry; later lookups continue the rotation.
Validation:
The ordinary signed Release build and strict signature check passed at exact head 6ce2ad3, with no warnings. The app was not launched. Exact-head CI34401335479 passed both required checks: build-and-test and website-smoke. The optional Vercel preview hit the daily deployment limit; website bytes are unchanged from verified production. CodeRabbit did not perform a review because of its quota; the independent source reviews above are the review evidence. Native AX timing, focus, permissions, keyboard and VoiceOver acceptance remain pending. No benchmark measurements or new public binary are included.