Skip to content

Add local image copies to File Shelf - #111

Merged
niharnm merged 11 commits into
mainfrom
nihar/image-copy-integration
Sep 9, 2026
Merged

niharnm merged 11 commits into
mainfrom
nihar/image-copy-integration

Conversation

@niharnm

@niharnm niharnm commented Sep 9, 2026

Copy link
Copy Markdown
Owner

File Shelf can now resize one fully local JPEG or PNG into a separate copy at a longest edge of 1,024 or 2,048 pixels. It previews dimensions, refuses enlargement and overwrites, preserves format, orientation, color profile and PNG transparency, and removes descriptive metadata. Saving requires a destination that supports macOS file cloning.

Cancellation and failed cleanup retain the affected file access until recovery completes. A recovered copy keeps its verified path visible until the user selects Done. If an edited or deleted output cannot be verified, Finish Without Verification ends tracking only after private cleanup and never deletes or republishes the public copy. Source documentation and website details accompany the feature; the website release date is also corrected to GitHub's published date.

Validation:

  • Signed Debug build passed at a575a87. Four strict signature checks and all 2,245 compiled unit tests across 255 suites passed, with no exclusions.
  • Signed Release build and strict app signature check passed at 682cde2, with no build warnings. The app was not launched.
  • App inputs at final head 4065a28 are unchanged from both signed builds. Documentation and website differences were verified by exact hashes. One test-only property reference was then made explicit for CI compiler compatibility; all 15 Shelf session tests and scoped formatting passed after this correction.
  • Independent source reviews covered file ownership, recovery, rendered action routing and the combined lifecycle/shell changes. Four final receipt regression tests passed independently from frozen source files, with a recorded failing-before case.
  • Final website checker passed 5 pages and 65 IDs; 11 tooling tests and 59 documentation links/anchors passed. Focused browser checks covered 360, 390 and 1,100 pixel widths, keyboard disclosure, focus and overflow. Mobile and desktop screenshots were independently inspected.

The first combined CI run exposed the test-fixture name-shadowing error before tests ran. It is corrected at 4065a28; fresh exact-head CI 34399700286 passed, including build-and-test and website-smoke. Native Save-dialog, keyboard, VoiceOver, permissions and physical-volume acceptance remain pending. No benchmark measurements or new public binary are included. Production website bytes will be verified after merge.

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
semper Ready Ready Preview Sep 9, 2026 8:04pm UTC
semper-vmf1 Ready Ready Preview Sep 9, 2026 8:04pm UTC

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: eb3a42e2-189f-4323-a98d-2544326a4894

📥 Commits

Reviewing files that changed from the base of the PR and between f3e278d and 4065a28.

📒 Files selected for processing (20)
  • README.md
  • ROADMAP.md
  • Semper/Modules/UtilityRuntime.swift
  • Semper/Modules/UtilityShellView.swift
  • Semper/Shelf/ShelfImageCopy.swift
  • Semper/Shelf/ShelfImageCopySession.swift
  • Semper/Shelf/ShelfImageCopyView.swift
  • Semper/Shelf/ShelfImageFileOwnership.swift
  • Semper/Shelf/ShelfModels.swift
  • Semper/Shelf/ShelfService.swift
  • Semper/Shelf/ShelfViews.swift
  • SemperTests/DirectUtilityRuntimeTests.swift
  • SemperTests/ShelfImageCopySessionTests.swift
  • SemperTests/ShelfImageCopyTests.swift
  • SemperTests/ShelfTests.swift
  • guide/product-status.md
  • guide/shelf-image-copy.md
  • website/about.html
  • website/index.html
  • website/llms.txt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

Deployment failed for project semper-vmf1 with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/niharnsm-8472s-projects?upgradeToPro=build-rate-limit

@niharnm
niharnm merged commit ced1a2b into main Sep 9, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant