Add Choose Files to File Shelf - #104
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File Shelf previously required drag and drop to add files. Choose Files is now available in both Shelf views with Command-O, allowing multiple files and folders to be added as references while originals remain unchanged.
The picker shares import admission, capacity, bookmarks, security scopes and cancellation. Cancel, Clear, Pause and Quit drain selection and reject late results. Access guidance now mentions both choosing and dropping an item.
Validation: 45 non-hosted Shelf tests passed, strict swift-format and git diff checks passed, and isolated build-for-testing passed with two jobs. Held picker fixtures remain pending until explicit release, with cancellation-aware observations and guaranteed drain.
Native dialog focus, cancellation and Command-O routing between compact and detail views remain quality-manager acceptance checks. No native UI tests or app launch ran for this PR.