Keep Presentation cancellation available during startup - #102
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presentation disabled every session button while preparing or starting, leaving its direct view without a cancellation control. Cancel Presentation now remains available beside progress, with Escape invoking the same action. It calls the existing stop path, which waits for pending work and restores applied changes.
Cancelled window receipts are retained before cancellation is handled, so recovery remains possible and failures remain visible. Cancellation is unavailable during recovery. Existing active-session End and Restore and confirmed Keep Current Setup behavior is unchanged.
Validation:
git diff --checkpassed.xcodebuild build-for-testingpassed with two build jobs and a separate DerivedData directory.34374508846passed on the revised test-synchronization head629ef7c.The change is isolated from the current accepted candidate at
fb9a3d5. File Shelf and Window Layout are separate work.