Skip to content

feat: add UI ssh key pair generator#809

Open
antoine-sh wants to merge 6 commits into
nicotsx:mainfrom
antoine-sh:feat/ssh-key-generator
Open

feat: add UI ssh key pair generator#809
antoine-sh wants to merge 6 commits into
nicotsx:mainfrom
antoine-sh:feat/ssh-key-generator

Conversation

@antoine-sh

@antoine-sh antoine-sh commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Proposition to solve #589 issue by adding ssh key generation buttons on sftp volume & repository creation pages.

  • Adds a new ssh utils file with the keypair generation function
  • The key is generated in browser and auto-fills the form fill
  • Adds a Copy public key button that enables after keypair generation
  • Nice little description message and error message if it fails

@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9bad6a58-579a-4296-9e86-2a2c134859ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@antoine-sh antoine-sh changed the title feat: add ssh private key generator feat: add UI ssh key pair generator Apr 18, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is duplicated exactly across both forms. Make it a re-usable component

return;
}
try {
await navigator.clipboard.writeText(generatedPublicKey);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy to clipboard will never work if not on https or localhost. So a user using an ip 192.168.1.10 will never be able to get their public key. Maybe you could render a read-only input for the public key. I prefer to avoid the clipboard api altogether

@nicotsx

nicotsx commented Jun 10, 2026

Copy link
Copy Markdown
Owner

^ Sorry i wrote these comments long ago but forgot to post them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants