feat: add UI ssh key pair generator#809
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This code is duplicated exactly across both forms. Make it a re-usable component
| return; | ||
| } | ||
| try { | ||
| await navigator.clipboard.writeText(generatedPublicKey); |
There was a problem hiding this comment.
Copy to clipboard will never work if not on https or localhost. So a user using an ip 192.168.1.10 will never be able to get their public key. Maybe you could render a read-only input for the public key. I prefer to avoid the clipboard api altogether
|
^ Sorry i wrote these comments long ago but forgot to post them |
Proposition to solve #589 issue by adding ssh key generation buttons on sftp volume & repository creation pages.