Repository navigation
fix(wpf): harden restore completion and consent - #11
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41ed18a4a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Rect workArea = SystemParameters.WorkArea; | ||
| MaxWidth = Math.Max(MinWidth, Math.Min(960, workArea.Width - workAreaInset)); | ||
| MaxHeight = Math.Max(MinHeight, workArea.Height - workAreaInset); |
There was a problem hiding this comment.
Constrain the dialog against its owner's monitor
When the owner is on a secondary monitor whose effective work area is smaller than the primary display's, SystemParameters.WorkArea returns the primary monitor's work area, so this calculation can leave the centered dialog at 680×620 even though it does not fit the monitor where it opens. That can place the Restore/Cancel row offscreen on mixed-resolution or mixed-DPI setups; derive the work area from the owner/window's monitor instead.
Useful? React with 👍 / 👎.
Summary
Verification
dotnet build src\WinRestoreKit.Tests\WinRestoreKit.Tests.csproj -c CodexFinal --no-restoredotnet formatcompleted successfully.git diff --checkcompleted successfully.Stack
This narrow draft PR is stacked on
codex/wpf-restore-integrityand should be reviewed after PR #10.