Add IntoIterator impl for Vector<T>#13
Open
mattwparas wants to merge 5 commits into
Open
Conversation
Owner
|
Hi, thanks for this PR, I'm very sorry I'm only noticing it now. Could you remove the extra formatting for the PR? Looks like it should be mostly a matter of squashing the commits into one and only keeping intoiter.rs in the final commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed an iterator that consumed the vector by value rather than getting it by reference. I followed the implementation from the rust nomicon. Locally all the tests pass and the miri tests pass minus the existing failure for
drain1.It looks like rust fmt ran on the whole repo - if you'd like I can adjust the diff to just include the changes from the one additional file if you'd like.
Happy to make any other changes as needed.