Skip to content

Adopt TypeScript 5.9 - #50

Open
m-akinc wants to merge 19 commits into
archives/fast-element-1from
users/makinc/fast-update-typescript
Open

Adopt TypeScript 5.9#50
m-akinc wants to merge 19 commits into
archives/fast-element-1from
users/makinc/fast-update-typescript

Conversation

@m-akinc

@m-akinc m-akinc commented Aug 20, 2026

Copy link
Copy Markdown

Pull Request

📖 Description

Align typescript version to align with Nimble Angular 21 changes and update dependencies.

  • Explicitly updated dependencies:
  • Removed rollup-plugin-filesize
    • Hasn't been updated in a long time and has stale transitive deps
  • Consequences of typescript update:
    • switched from "importsNotUsedAsValues": "error" (unsupported since 5.5) to "verbatimModuleSyntax": true
    • removed deprecated "suppressImplicitAnyIndexErrors": true" option (unsupported since 5.5)
      • caused additional type errors to no longer be suppressed. Addressed by either using explicit any types where it made sense locally or added @ts-expect-error statements to address in future refactors (defining better global types, etc
  • Consequences of eslint update:
    • migrated old .eslintrc config files to modern, flat configs
    • removed lint rule suppressions that either were already moot, or became moot due to a rule being removed from the "recommended" ruleset (e.g. @typescript-eslint/no-non-null-assertion)
  • Switched to package.json of "type": "module"

npm outdated results:

  • Downstream Angular version gates: eslint, typescript
  • chai requires refactoring
  • @types/node aligns with GitHub Actions version
  • react should be removed in future update (fast-react not leveraged by nimble-react anymore)
  • prettier should be removed in future update (nimble removed prettier and should align)
Package           Current   Wanted   Latest
@eslint/js         9.39.5   9.39.5   10.0.1
@types/chai        4.3.20   4.3.20    5.2.3
@types/chai        4.3.20   4.3.20    5.2.3
@types/chai        4.3.20   4.3.20    5.2.3
@types/chai        4.3.20   4.3.20    5.2.3
@types/chai        4.3.20   4.3.20    5.2.3
@types/node       24.13.3  24.13.3   26.3.0
@types/react      18.3.31  18.3.31  19.2.18
@types/react-dom   18.3.7   18.3.7   19.2.5
chai                4.5.0    4.5.0    6.2.2
chai                4.5.0    4.5.0    6.2.2
chai                4.5.0    4.5.0    6.2.2
chai                4.5.0    4.5.0    6.2.2
chai                4.5.0    4.5.0    6.2.2
eslint             9.39.5   9.39.5   10.9.1
prettier            3.4.2    3.4.2    3.9.6
prettier            3.4.2    3.4.2    3.9.6
prettier            3.4.2    3.4.2    3.9.6
prettier            3.4.2    3.4.2    3.9.6
prettier            3.4.2    3.4.2    3.9.6
prettier            3.4.2    3.4.2    3.9.6
react              18.3.1   18.3.1   19.2.8
react-dom          18.3.1   18.3.1   19.2.8
typescript          5.9.3    5.9.3    7.0.2
typescript          5.9.3    5.9.3    7.0.2
typescript          5.9.3    5.9.3    7.0.2
typescript          5.9.3    5.9.3    7.0.2
typescript          5.9.3    5.9.3    7.0.2
typescript          5.9.3    5.9.3    7.0.2

@m-akinc m-akinc changed the title Update dependencies on typescript/eslint/typescript-eslint and remove rollup-plugin-filesize Update dependencies on typescript/eslint/typescript-eslint and remove rollup-plugin-filesize and rimraf Aug 20, 2026
Comment thread packages/web-components/fast-foundation/package.json Outdated
@m-akinc m-akinc changed the title Update dependencies on typescript/eslint/typescript-eslint and remove rollup-plugin-filesize and rimraf Update dependencies on typescript/eslint/typescript-eslint and remove rollup-plugin-filesize Aug 20, 2026
@m-akinc
m-akinc force-pushed the users/makinc/fast-update-typescript branch from 8d0cd14 to 51b4756 Compare August 20, 2026 22:26
@m-akinc
m-akinc marked this pull request as ready for review August 21, 2026 00:32
@m-akinc
m-akinc requested a review from jattasNI as a code owner August 21, 2026 00:32
@m-akinc
m-akinc requested a review from rajsite August 21, 2026 00:32
Comment thread packages/web-components/fast-foundation/src/number-field/number-field.spec.ts Outdated
@m-akinc
m-akinc force-pushed the users/makinc/fast-update-typescript branch from 2768f07 to 3f3af1a Compare August 21, 2026 22:56
@m-akinc
m-akinc requested a review from rajsite August 21, 2026 23:19
Comment thread change/@ni-eslint-config-fast-dna-94274775-339e-4fcb-9027-34ecb471a249.json Outdated
Comment thread change/@ni-eslint-config-fast-dna-94274775-339e-4fcb-9027-34ecb471a249.json Outdated
Comment thread packages/web-components/fast-foundation/tsconfig.json Outdated
Beachball doesn't handle the string "true" correctly only the actual bool
@rajsite rajsite changed the title Update dependencies on typescript/eslint/typescript-eslint and remove rollup-plugin-filesize Adopt TypeScript 5.9 Aug 26, 2026
@@ -0,0 +1,7 @@
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep TS versions aligned should wait until ready to start merging angular 21 changes to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants