Skip to content

test: re-enable skipped tests - #5220

Merged
markostanimirovic merged 3 commits into
mainfrom
test-skipped
Sep 10, 2026
Merged

markostanimirovic merged 3 commits into
mainfrom
test-skipped

Conversation

@timdeschryver

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There are skipped tests

What is the new behavior?

There are no skipped tests:

  • tests are removed
  • updated

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify

netlify Bot commented Aug 31, 2026

Copy link
Copy Markdown

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit f11ab68
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6aa2707b0f82ae00088f167c
😎 Deploy Preview https://deploy-preview-5220--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@timdeschryver timdeschryver changed the title Test skipped test: re-enable skipped tests Aug 31, 2026
});
}));

test.skip('should support preventing navigation', () =>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RxJS 6 this isn't support anymore because subscriber errors are reported asynchronously

@markostanimirovic
markostanimirovic merged commit ee3d3e9 into main Sep 10, 2026
10 checks passed
@markostanimirovic
markostanimirovic deleted the test-skipped branch September 10, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants