fix(signals): preserve entity when id changes number to equivalent string - #5219
Merged
timdeschryver merged 1 commit intoAug 31, 2026
Merged
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
markostanimirovic
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
#5218
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In
updateEntitiesMutably(used byupdateEntity,updateEntities, andupdateAllEntities), when an entity's ID is changed to a value that is a different type but the same object key (e.g. numeric1to string'1'), the entity is deleted instead of updated. This happens because the new key is written before the old key is deleted, and JavaScript treats1and'1'as the same object property, so the delete step removes the just-written entity.Reproduction:
What is the new behavior?
The old entity key is deleted before the updated entity is assigned to the new key, so entities are preserved when the ID's string/number representation changes.
entityMap,ids, andentitiesall stay consistent.A regression test was added in
update-entity.spec.tscovering the numeric-to-string ID update case.Does this PR introduce a breaking change?
No