Conversation
There are plenty of environments without BASH, but with sh.
These could have caused problems: $!"\
- exit if directory doesn't exist - source .profile only if it exists - don't suppress stderr while doing that
The output padding is based upon the longest name of processes and thus never changes at runtime so we can optimize things a bit by only creating the output formatter pattern once at startup.
mirroring what's being done with docker-gen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of ddollar#124 by @sehrope
The original PR also included this:
Which has been replaced by a similar version injection closer to what we already do in docker-gen.