fix(report): hide the in-app overlay before scanning, so contrast below the fold is checked (0.15.8) - #32
Merged
Conversation
…ow the fold is checked (0.15.8) The overlay's tab-order path is a fixed SVG that overflows the viewport. axe's color-contrast counted it as covering text below the fold and returned incomplete (bgOverlap), which report mode doesn't list, so contrast below the first 900px went unreported in light and dark passes. Report mode now hides [data-ngb-a11y-overlay] before axe runs. New E2E page reproduces it and fails without the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Report mode now hides the in-app overlay (
[data-ngb-a11y-overlay]) before axe runs.Why
When the target app runs the overlay, its tab-order path is drawn on a fixed SVG that overflows the viewport. axe's
color-contrastcounted it as covering text below the fold and returned incomplete (bgOverlap). Report mode only lists violations, so contrast problems below the 900px-tall report viewport went unreported, in light and dark passes.Found on the public demo: two dark-mode contrast failures the
--dark-attributepass missed. With this change it reports them.Tests
/overlay-below-fold(a shown popover layer with an overflowing SVG and a pill button). Fails without the fix, passes with it.Releases as 0.15.8.
🤖 Generated with Claude Code