fix(overlay): tab-order badges and finding labels pass contrast (0.15.7) - #31
Merged
Merged
Conversation
White 10px digits sat on #0b8f8f at 3.93:1; axe flagged them on a dark-mode page (admin example). The warning badge (#e8710a) was 3.09:1. Fills are now #0a7a7a (5.15:1) and #b45309 (5.02:1); the connector lines keep the brighter teal. New specs assert >= 4.5:1 for both and fail on the old colours. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
White 11px label text sat on the impact colour: serious 3.09, moderate 2.42, minor 4.11, none 3.45. Labels get their own fills in the same hue (#b45309, #8a6d00, #2563c4, #666666; critical keeps #d32029), all >= 4.9:1; box outlines keep the impact colours. Specs cover every impact (4 fail on the old fills). Connector comment no longer claims a ratio. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the board card "a11y-devtools: tab-order badges fail contrast in dark mode (3.93:1)". axe flagged the overlay on the dark-mode admin example.
Changes (0.15.7)
#0b8f8fwere 3.93:1. The fill is now#0a7a7a(5.15:1). The positive-tabindex badge#e8710a(3.09:1) is now#b45309(5.02:1). The connector lines keep their teal.#b45309,#8a6d00,#2563c4and#666666(critical keeps#d32029), all at least 4.9:1. Box outlines keep the impact colours.Tests 314/314, build OK. Subagent pre-review: the label fix came from it. The other overlay pairs (Focus preview card, pill) pass.
🤖 Generated with Claude Code