Split docs into own on-call thread reply + link channels - #18
Merged
Conversation
Move the docs link out of the start-of-week responsibilities message and post it as a separate third thread reply under the weekly on-call announcement. Render the #release-review-trading, #request-core and #github-invitations references as clickable Slack channel links (falling back to plain #name text when the channel ID can't be resolved). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Monday announcement thread now posts three replies (responsibilities, proposals digest, docs link) and resolves channel IDs for the channel links in the responsibilities message. Patch resolve_channel_id and assert the docs reply and the rendered <#ID> channel link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tidies up the weekly on-call announcement thread in
scheduler/oncall_jobs.py:Docs: …line is removed from the start-of-week responsibilities reply and posted as a separate third thread reply (after the responsibilities reminder and the proposals digest).#release-review-trading,#request-core, and#github-invitationsin the responsibilities message now render as clickable Slack channel links (<#ID>), falling back to plain#nametext if the channel ID can't be resolved (e.g. the bot isn't a member).The thread now posts three independent, best-effort replies: responsibilities → proposals digest → docs.
Implementation notes
resolve_channel_id()helper fromproposals/slack_utils.py(process-lifetime cached), which is why the responsibilities text is now built dynamically rather than as a static constant.try/exceptso a failure posting one doesn't block the others.🤖 Generated with Claude Code