Skip to content

Reshape proposal-review skill around its Slack output - #17

Merged
ewels merged 3 commits into
mainfrom
proposal_review_tweaks
Jun 18, 2026
Merged

Reshape proposal-review skill around its Slack output#17
ewels merged 3 commits into
mainfrom
proposal_review_tweaks

Conversation

@ewels

@ewels ewels commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

The nfcore-proposal-review skill was structured as a general "upstream" skill plus a runtime addendum that overrode the body for the Slack-bot context — which is the only context the skill ever runs in. This reshapes it around that single reality.

  • Folded the addendum into the body. Tooling (run_command, bundled scripts, gh/jq/nf-core), the "proposal is already provided" note, and the Slack message format are now the primary spec rather than overrides tacked on the end.
  • One canonical output structure — the Slack verdict message + a single draft GitHub comment code block. Dropped the old verdict-block + analysis-narrative format that the addendum overrode anyway, and removed the batch-sweep mode (Slack always reviews one proposal).
  • De-shouted the prose — verdict tokens and status markers to title case (e.g. CONDITIONAL_ACCEPT → Conditional Accept, PASS/FAIL → Pass/Fail), underscores to spaces in prose. Code identifiers, URLs, and acronyms (CI, SIG, DRAGEN, GxP) left as-is.
  • Fixed invalid YAML frontmatter. The description's Triggers on: "..." colon-space parsed as a nested mapping key. Switched to a folded block scalar (>-), matching the slack-app skill convention.

Test plan

  • Frontmatter parses as valid YAML (verified with a YAML parser)
  • Spot-check a live proposal review renders correctly in Slack

🤖 Generated with Claude Code

ewels and others added 3 commits June 18, 2026 09:32
The skill carried a general "upstream" body plus a runtime addendum that
overrode it for the only context the skill ever runs in (the Slack bot).
Fold the addendum in and drop the dual framing: tooling, "proposal already
provided", and the Slack message format are now the primary spec, with a
single canonical output structure (Slack verdict + draft GitHub comment).

Also de-shout the prose (verdict tokens and status markers to title case,
underscores to spaces) and fix the YAML frontmatter, which was invalid
because the description's "Triggers on: ..." colon-space parsed as a nested
mapping key. Switched description to a folded block scalar (>-), matching
the slack-app skill convention.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ewels
ewels marked this pull request as ready for review June 18, 2026 21:22
@ewels
ewels merged commit a8063a7 into main Jun 18, 2026
2 checks passed
@ewels
ewels deleted the proposal_review_tweaks branch June 18, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant