Reshape proposal-review skill around its Slack output - #17
Merged
Conversation
The skill carried a general "upstream" body plus a runtime addendum that overrode it for the only context the skill ever runs in (the Slack bot). Fold the addendum in and drop the dual framing: tooling, "proposal already provided", and the Slack message format are now the primary spec, with a single canonical output structure (Slack verdict + draft GitHub comment). Also de-shout the prose (verdict tokens and status markers to title case, underscores to spaces) and fix the YAML frontmatter, which was invalid because the description's "Triggers on: ..." colon-space parsed as a nested mapping key. Switched description to a folded block scalar (>-), matching the slack-app skill convention. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ewels
marked this pull request as ready for review
June 18, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
nfcore-proposal-reviewskill was structured as a general "upstream" skill plus a runtime addendum that overrode the body for the Slack-bot context — which is the only context the skill ever runs in. This reshapes it around that single reality.run_command, bundled scripts,gh/jq/nf-core), the "proposal is already provided" note, and the Slack message format are now the primary spec rather than overrides tacked on the end.CONDITIONAL_ACCEPT→ Conditional Accept,PASS/FAIL→ Pass/Fail), underscores to spaces in prose. Code identifiers, URLs, and acronyms (CI, SIG, DRAGEN, GxP) left as-is.description'sTriggers on: "..."colon-space parsed as a nested mapping key. Switched to a folded block scalar (>-), matching theslack-appskill convention.Test plan
🤖 Generated with Claude Code