Re-write tests to UTILS.groovy style#294
Merged
Merged
Conversation
LouisLeNezet
requested changes
Jun 21, 2026
LouisLeNezet
left a comment
LouisLeNezet
left a comment
Collaborator
There was a problem hiding this comment.
As you renamed the tests, the snapshot now contains unused tests.
If you look at the PR details, most of the snapshot as something like +400 new lines while the one for glimpse1 only have +5 and -9 (which should be the case for all the snapshots).
Could you rename the snapshots test names and delete the unused / duplicate ?
Other wise I don't see any issue on this PR 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates nf-tests from its current structure to the
UTILS.groovyscenario structure, as done in nf-core/rnavar. This makes the test cases more concise.