Repository navigation
Fix path_or_url for wildcard inputs - #88
Merged
Merged
Conversation
Follow up on <#87 (comment)> We rely on the Snakemake inputs to expand wildcards without threading it through `path_or_url`, so we cannot check the existence of files with wildcards. Remove the check that the local file exists and update warning log with clear hint in case users run into MissingInputException.
3 tasks done
Contributor
Author
|
Will merge tomorrow and deal with downstream updates. Note to self: the update workflow triggered by the last PR did not update the private repo generic-pathogen. Will need do that manually and look into update workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
We rely on the Snakemake inputs to expand wildcards without threading it through
path_or_url, so we cannot check the existence of files with wildcards. Remove the check that the local file exists and update warning log with clear hint in case users run into MissingInputException.Related issue(s)
Follow up on #87 (comment)
Checklist