Repository navigation
Conversation
db08e96 to
bade472
Compare
5fa766e to
b77213d
Compare
c38407b to
f57365e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## victorlin/ancestral-config #2049 +/- ##
==============================================================
+ Coverage 74.56% 74.64% +0.08%
==============================================================
Files 86 86
Lines 10882 10898 +16
Branches 2123 2122 -1
==============================================================
+ Hits 8114 8135 +21
+ Misses 2373 2370 -3
+ Partials 395 393 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The newest commit f57365e is necessary for proper |
|
Moved f57365e and related changes to #2051.
I was wrong about this. We'd still need |
f57365e to
a071931
Compare
bade472 to
087da7d
Compare
a071931 to
9b23556
Compare
087da7d to
130695c
Compare
9b23556 to
2eb799b
Compare
2eb799b to
b1e78b7
Compare
b1e78b7 to
e9162c8
Compare
130695c to
70a97ed
Compare
$schema is used in the schema to refer to the meta-schema,¹ but it is also common practice to use the same key in schema-adherent files for strictness, similar to typing a variable in code. One benefit is IDE hints² for users who open these config files in a editor that understands this key, but more importantly we can use it in our own processing of config files. ¹ https://json-schema.org/understanding-json-schema/reference/schema#schema ² https://code.visualstudio.com/docs/languages/json#_json-schemas-and-settings
Split the Augur-loading functionality of `load_json_schema()` into a higher level function `load_augur_json_schema()` so that the former can be kept lower level. There are now two external facing functions with clear intent: `load_augur_json_schema()` and `load_json_schema_locally()`
This will be useful for loading from URLs from a $schema key.
Now that other commands accept config files with filepaths marked in schema, the generic get_referenced_files() function is necessary for adoption in Snakemake workflows where referenced files are to be listed as inputs for file change detection. Some changes were necessary as the previous subsample-specific function hardcodes the schema within the function. The generic function solves this by requiring the $schema key in the config. Keeping the subsample-specific function around because it's used by some workflows. Will remove once those workflows are updated to use the generic function.
70a97ed to
e2737ae
Compare
e9162c8 to
bb28bc5
Compare
|
Moving these changes to #2040 since they're required for that PR to work. |
Description of proposed changes
This PR contains 3 prep commits and 1 main commit. Message from main commit:
Now that other commands accept config files with filepaths marked in schema, the generic get_referenced_files() function is necessary for adoption in Snakemake workflows where referenced files are to be listed as inputs for file change detection.
Some changes were necessary as the previous subsample-specific function hardcoded the schema within the function. The generic function solves this by requiring the $schema key in the config.
Keeping the subsample-specific function around because it's used by some workflows. Will remove once those workflows are updated to use the generic function.
Related issue(s)
Follow-up to #2041 (comment)
Checklist