Skip to content

Use ruamel.yaml - #2046

Merged
victorlin merged 1 commit into
masterfrom
victorlin/use-ruamel.yaml
Sep 4, 2026
Merged

victorlin merged 1 commit into
masterfrom
victorlin/use-ruamel.yaml

Conversation

@victorlin

@victorlin victorlin commented Sep 3, 2026 •

Copy link
Copy Markdown
Member

Description of proposed changes

The main motivation is to have errors on duplicate keys, which PyYAML silently allows due to a longstanding bug.

The other notable difference is a switch from YAML 1.1 to YAML 1.2 (latest).

Related issue(s)

Follow-up to #2040 (comment)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

The main motivation is to have errors on duplicate keys, which PyYAML
silently allows due to a longstanding bug.¹

The other notable difference² is a switch from YAML 1.1 to YAML 1.2
(latest).

¹ yaml/pyyaml#165
² https://yaml.dev/doc/ruamel.yaml/pyyaml/
@victorlin victorlin self-assigned this Sep 3, 2026
@victorlin victorlin mentioned this pull request Sep 3, 2026
4 of 5 tasks
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.27%. Comparing base (7c7ac40) to head (a9e8d2f).

Files with missing lines Patch % Lines
augur/validate.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   73.26%   73.27%           
=======================================
  Files          86       86           
  Lines       10765    10767    +2     
  Branches     2099     2099           
=======================================
+ Hits         7887     7889    +2     
  Misses       2503     2503           
  Partials      375      375           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joverlee521 joverlee521 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up here!

@victorlin
victorlin merged commit dbf7faa into master Sep 4, 2026
35 checks passed
@victorlin
victorlin deleted the victorlin/use-ruamel.yaml branch September 4, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants