Skip to content

Repository navigation

ci: remove redundant qualification result job #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JJLiebig merged 1 commit into from
Oct 29, 2026
Merged

ci: remove redundant qualification result job #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,23 +101,11 @@ jobs:
- if: ${{ always() && github.event_name == 'pull_request' && (github.event.pull_request.head.repo.full_name != github.repository || github.actor == 'dependabot[bot]') }}
run: echo 'Owned artifact uploads are unavailable for fork and Dependabot checks.' >> "$GITHUB_STEP_SUMMARY"

result:
name: Qualification result
if: ${{ always() }}
needs: correctness
runs-on: [self-hosted, Linux, X64, nextide-ci-docker]
timeout-minutes: 5
steps:
- name: Require selected groups
- name: Qualification summary
if: ${{ always() }}
env:
PROFILE: ${{ inputs.profile || 'full' }}
SOURCE_SHA: ${{ needs.correctness.outputs.sha || inputs.source_sha || github.sha }}
CORRECTNESS: ${{ needs.correctness.result }}
SOURCE_SHA: ${{ steps.source.outputs.sha || inputs.source_sha || github.sha }}
CORRECTNESS: ${{ job.status }}
run: |
node <<'NODE'
const { PROFILE, SOURCE_SHA, CORRECTNESS } = process.env;
console.log(`Qualification ${PROFILE}: ${SOURCE_SHA}; Correctness=${CORRECTNESS}`);
if (!["full", "deploy"].includes(PROFILE) || CORRECTNESS !== "success") {
process.exit(1);
}
NODE
printf 'Qualification %s: %s; Correctness=%s\n' "$PROFILE" "$SOURCE_SHA" "$CORRECTNESS" | tee -a "$GITHUB_STEP_SUMMARY"
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Pull requests, main pushes, and the weekly **Qualification** workflow run full q
`full` or `deploy`; deploy deliberately skips **Quality**. Both profiles share one
Node installation in **Correctness / Package and browser**. Full runs execute
Quality first; its full lint also covers correctness lint and the watchlist.
**Qualification result** requires the selected checks to succeed and reports the validated commit. The
That job requires the selected checks to succeed and reports the profile, validated commit, and status. The
package has no service deployment or database integration lane; its integration
surface is the packed consumer and playground browser suite.

Expand Down