feat(Viewer): add zoom and pan to image viewer#1756
Open
vladopol wants to merge 1 commit into
Open
Conversation
6f33707 to
e9e75ef
Compare
Member
|
You need to sign-off your commits otherwise we can not merge them at all |
Install panzoom library (9.4.4, 6 kB) and apply it to the image viewer wrapper in ViewerHandlerImages.vue: - Scroll wheel to zoom in/out (1× – 8×) - Drag to pan when zoomed in - Double-click to zoom in 3× at cursor, double-click again to reset - Auto-center image when zoom returns to 1× - Pan blocked at minimum zoom to prevent accidental shifts - Cursor changes: zoom-in at 1×, grab/grabbing when zoomed Fixes nextcloud#1535 Signed-off-by: Vladimir Poluliashenko <vladopol@gmail.com>
e9e75ef to
1fda3da
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds zoom and pan support to the image viewer in Talk Desktop, addressing the long-standing macOS limitation where pinch-to-zoom had no effect and Cmd+/- zoomed the entire application UI instead of the image.
Installs
panzoom(v9.4.4, 6 kB) — same library already used in spreed for screen share zoom (spreed#14028).Changes in
ViewerHandlerImages.vue:zoom-inat 1×,grab/grabbingwhen zoomedTest plan
Closes #1535