chore(config): recatore next batch of Talk App configs to new AppConfig Framework - #19169
Open
sudormant wants to merge 2 commits into
Open
chore(config): recatore next batch of Talk App configs to new AppConfig Framework#19169sudormant wants to merge 2 commits into
sudormant wants to merge 2 commits into
Conversation
…ig framework Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
added
feature: settings ⚙️
| | `call_end_to_end_encryption` | bool | `false` | No | 🖌️ | Whether clients should end-to-end encrypt streams in calls (Only supported with High-performance backend) | | ||
| | `inactivity_lock_after_days` | int | `0` | No | | A duration (in days) after which rooms are locked. Calculated from the last activity in the room. | | ||
| | `inactivity_enable_lobby` | bool | `false` | No | | Additionally enable the lobby for inactive rooms so they can only be read by moderators. | | ||
| | `backgrounds_branded_for_guests` | bool` | `false` | No | | Whether guests are allowed to use the virtual backgrounds provided via `themes/talk-backgrounds/` | |
Member
There was a problem hiding this comment.
Suggested change
| | `backgrounds_branded_for_guests` | bool` | `false` | No | | Whether guests are allowed to use the virtual backgrounds provided via `themes/talk-backgrounds/` | | |
| | `backgrounds_branded_for_guests` | bool | `false` | No | | Whether guests are allowed to use the virtual backgrounds provided via `themes/talk-backgrounds/` | |
| | invite | participant2 | | ||
| And the following "spreed" app config is set | ||
| | delete_one_to_one_conversations | 1 | | ||
| | delete_one_to_one_conversations | ttrue | |
Member
There was a problem hiding this comment.
Suggested change
| | delete_one_to_one_conversations | ttrue | | |
| | delete_one_to_one_conversations | true | |
|
|
||
| public function getPlaySoundsDefaultForGuests(): bool { | ||
| return $this->appConfig->getAppValueBool('guests_play_sounds', true); | ||
| return $this->appConfig->getAppValueBool(self::GUESTS_PLAY_SOUNDS, true); |
Member
There was a problem hiding this comment.
Suggested change
| return $this->appConfig->getAppValueBool(self::GUESTS_PLAY_SOUNDS, true); | |
| return $this->appConfig->getAppValueBool(self::GUESTS_PLAY_SOUNDS); |
Should work?
…ig framework, typo fixes Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
docs/has been updated or is not required