Skip to content

fix: Send read marker only when session is active - #19097

Open
SystemKeeper wants to merge 2 commits into
mainfrom
fix/18734/session-state-unread-marker
Open

fix: Send read marker only when session is active#19097
SystemKeeper wants to merge 2 commits into
mainfrom
fix/18734/session-state-unread-marker

Conversation

@SystemKeeper

@SystemKeeper SystemKeeper commented Aug 26, 2026 •
edited by Antreesy
Loading

Copy link
Copy Markdown
Contributor

☑️ Resolves

Not risky to browser differences / client

Since the mechanism is the same as before, I think it should not be risky?

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@SystemKeeper SystemKeeper added this to the ⛅ Next Beta/RC (35) milestone Aug 26, 2026
@SystemKeeper SystemKeeper self-assigned this Aug 26, 2026
@SystemKeeper SystemKeeper added bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Aug 26, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Aug 26, 2026
@SystemKeeper SystemKeeper changed the title Fix/18734/session state unread marker fix: Send unread marker only when session is active Aug 26, 2026
Antreesy
Antreesy reviewed Aug 26, 2026
View reviewed changes

@Antreesy Antreesy left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea makes sense to me, let's polish it slightly

I think it should not be risky?

Chrome doesn't fire 'visibilitychange' event same way as e.g. Firefox, so you never know =)

Comment thread src/composables/useActiveSession.js Outdated
Comment thread src/composables/useActiveSession.js Outdated
Comment thread src/composables/useActiveSession.js
@SystemKeeper
SystemKeeper force-pushed the fix/18734/session-state-unread-marker branch from 7fa910a to 386acb3 Compare August 26, 2026 16:28
@SystemKeeper
fix: Sending read-marker while session is inactive
b7a6696 
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeper force-pushed the fix/18734/session-state-unread-marker branch from 386acb3 to 18c61e9 Compare August 26, 2026 16:29
@SystemKeeper
fix: Set session inactive after 1 minute
7f7a20b 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeper force-pushed the fix/18734/session-state-unread-marker branch from 18c61e9 to 7f7a20b Compare August 26, 2026 16:30
@SystemKeeper
SystemKeeper requested a review from Antreesy August 26, 2026 16:30
@SystemKeeper SystemKeeper changed the title fix: Send unread marker only when session is active fix: Send read marker only when session is active Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad
@Antreesy Antreesy Awaiting requested review from Antreesy

At least 1 approving review is required to merge this pull request.

Assignees

@SystemKeeper SystemKeeper

Labels

AI assisted This PR contains AI-assisted commits bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

⛅ Next RC (35)

Development

Successfully merging this pull request may close these issues.

Messages marked as read when session is inactive

3 participants

@SystemKeeper @Antreesy @nextcloud-command