fix(call): stop conversation-joined watcher on immediate match - #19092
Open
Antreesy wants to merge 1 commit into
Open
fix(call): stop conversation-joined watcher on immediate match#19092Antreesy wants to merge 1 commit into
Antreesy wants to merge 1 commit into
Conversation
- switch to @vueuse library implementation of whenever - immediate + once matches how we use it - whenever stops the watcher on immediate match, resolving the stray watcher issue Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
bug
regression
feature: frontend 🖌️
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
{ immediate: true }, callback ran before stopWatch was returned@vueuselibrary implementation ofwhenever()- immediate + once matches how we use it (alternative is to keep current implementation and stopWatch before/after the callback)To test:
.../index.php/call/{token}#direct-call, join callAI (if applicable)
🖌️ UI Checklist
🏁 Checklist