Skip to content

feat(settings): split default camera and microphone settings into separate toggles - #19034

Draft
max65482 wants to merge 2 commits into
nextcloud:mainfrom
max65482:feat/separate-audio-video-default-setting
Draft

feat(settings): split default camera and microphone settings into separate toggles#19034
max65482 wants to merge 2 commits into
nextcloud:mainfrom
max65482:feat/separate-audio-video-default-setting

Conversation

@max65482

@max65482 max65482 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (Github Copilot, GPT-5.6 Luna)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
before after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@max65482
max65482 force-pushed the feat/separate-audio-video-default-setting branch from 1b53244 to 8d37e88 Compare August 19, 2026 18:32
…les, Assisted-by: Copilot:gpt-5.6-luna

Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
@max65482
max65482 force-pushed the feat/separate-audio-video-default-setting branch from 8d37e88 to 8bffb12 Compare August 19, 2026 18:36

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Needs a backender to review it before continue.

From a quick glance - we can't just drop a config option from v20.1, it needs to be deprecated as minimum; existing values set on server can be migrated to maintain behaviour (previous: true -> audio: true + video: true), client should check if server supports new options, otherwise fall back to pre-existing one (e.g. if new client used with old server)

@max65482

Copy link
Copy Markdown
Contributor Author

Thanks for the hint! Added backward and forward compatibility.
(Marking as draft since I haven't fully tested it yet.)

@max65482
max65482 marked this pull request as draft August 20, 2026 18:47
@max65482
max65482 force-pushed the feat/separate-audio-video-default-setting branch 2 times, most recently from 50ee006 to b2fa3c8 Compare August 21, 2026 11:22
…luna

Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
@max65482
max65482 force-pushed the feat/separate-audio-video-default-setting branch from b2fa3c8 to ad59add Compare August 21, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split default camera and microphone settings into separate toggles

2 participants