feat(settings): split default camera and microphone settings into separate toggles - #19034
Draft
max65482 wants to merge 2 commits into
Draft
feat(settings): split default camera and microphone settings into separate toggles#19034max65482 wants to merge 2 commits into
max65482 wants to merge 2 commits into
Conversation
max65482
force-pushed
the
feat/separate-audio-video-default-setting
branch
from
August 19, 2026 18:32
1b53244 to
8d37e88
Compare
…les, Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
max65482
force-pushed
the
feat/separate-audio-video-default-setting
branch
from
August 19, 2026 18:36
8d37e88 to
8bffb12
Compare
Antreesy
reviewed
Aug 20, 2026
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution!
Needs a backender to review it before continue.
From a quick glance - we can't just drop a config option from v20.1, it needs to be deprecated as minimum; existing values set on server can be migrated to maintain behaviour (previous: true -> audio: true + video: true), client should check if server supports new options, otherwise fall back to pre-existing one (e.g. if new client used with old server)
Contributor
Author
|
Thanks for the hint! Added backward and forward compatibility. |
max65482
marked this pull request as draft
August 20, 2026 18:47
max65482
force-pushed
the
feat/separate-audio-video-default-setting
branch
2 times, most recently
from
August 21, 2026 11:22
50ee006 to
b2fa3c8
Compare
…luna Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
max65482
force-pushed
the
feat/separate-audio-video-default-setting
branch
from
August 21, 2026 12:09
b2fa3c8 to
ad59add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required