fix: show a single duplicate-name error during file creation - #62767
Open
mvanhorn wants to merge 1 commit into
Open
fix: show a single duplicate-name error during file creation#62767mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
mvanhorn
requested review from
kristian-zendato and
susnux
and removed request for
a team
August 2, 2026 07:23
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep
validityas the single source for the inlineNcTextFielderror and retain the input's custom validity state so form submission, including Enter-key submission, remains blocked for duplicate and otherwise invalid names. Stop proactively invoking native validity reporting when reactive validation changes, which removes the transient browser tooltip without weakening the existing constraint. Add focused component coverage around the duplicate-name state, verifying the inline error, disabled Create action, retained native invalid state, and absence of areportValidity()call.The web file-creation dialog currently displays the duplicate-name validation twice: once as the intended red
NcTextFieldhelper text and once as a browser-native validation tooltip.NewNodeDialog.vuecreates both channels by bindingvalidityto the field's error/helper props while also callingreportValidity()after setting a custom validity message. The issue is reproducible by entering the name of an existing file or folder in the same directory. The desired behavior is one persistent inline error with creation still blocked until the name becomes valid.Fixes #62686
TODO
Checklist
Not verified: this needs a person on the named hardware or environment.
3. to review, feature component)Not run: no test command resolved in this workspace, so nothing was executed to pass.
stable32)Not run: no test command resolved in this workspace, so nothing was executed to pass.
AI (if applicable)
AI was used for assistance.